fix(tests): Conform to upcoming expectRevert behavior
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
May 17, 2023
|
Should be good to go now! @mds1 |
Evalir
force-pushed
the
evalir/fix_revert_test
branch
from
394efef
to
9db38e6
Compare
mds1
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
Sorry missed that this was ready, thanks @Evalir! Looks like CI is passing—am I correct that this can be merged now (without waiting for v1 release) since this fix is compatible both with current and future (v1) expectRevert behavior?
|
Yep indeed can be merged now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to foundry-rs/foundry#4945
The new expectRevert behavior means that it will only check the next call, instead of checking a revert at the "test" level. Some of the tests in
forge-stdexpected the latter behavior, but with the linked PR this will change. This updates the tests to comply to the new behavior.