Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix digests of layers meta #352

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix digests of layers meta #352

merged 2 commits into from
Oct 2, 2024

Conversation

mike-sul
Copy link
Contributor

@mike-sul mike-sul commented Oct 1, 2024

Fix two issues detected while testing edge cases.

  1. Layer digests should be set and used in a full format with the algorithm prefix.
  2. Take into account that the docker daemon uses short form references for images hosted in docker.io during getting information about image layers.

Represent layer digest with the algorithm prefix so layers are
consistently identified when layers metadata are stored and used.

Signed-off-by: Mike Sul <[email protected]>
Images hosted in the docker.io hub are referenced in a short form
without `docker.io` or `docker.io/library` prefixes. Therefore, the
algorithm should take it into account when looking for an image in the
local docker store (`repositiories.io`).

Signed-off-by: Mike Sul <[email protected]>
@mike-sul mike-sul requested a review from doanac October 1, 2024 15:15
@mike-sul mike-sul merged commit 708c70a into master Oct 2, 2024
2 checks passed
@mike-sul mike-sul deleted the fix-digests-of-layers-meta branch October 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants