Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmp/build: check availability of the image manifest #313

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quaresmajose
Copy link
Member

@quaresmajose quaresmajose commented Nov 3, 2023

Skip the loop if image manifest not found, instead of failing blindly.
Also show some status about not found license manifests.

Fix the following:

| + for img in ${DEPLOY_DIR_IMAGE}/*${MACHINE}.manifest
| ++ basename '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest'
| ++ sed -e s/.manifest//
| + image_name='*intel-corei7-64'
| ++ readlink '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest'
| ++ sed -e 's/\..*manifest//'
| + image_name_id=
| Script completed with error(s)

@quaresmajose
Copy link
Member Author

quaresmajose commented Nov 3, 2023

Validated with lmp-base distro

@quaresmajose
Copy link
Member Author

In this case the file not exist and so the glob will not expand

+ for img in ${DEPLOY_DIR_IMAGE}/*${MACHINE}.manifest
+ '[' -e '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest' ']'
+ status 'Image manifest not found, license manifest will be skipped'
++ date '+%F %T'
+ echo == 2024-09-30 17:10:08 Image manifest not found, license manifest will be skipped
+ break
== 2024-09-30 17:10:08 Image manifest not found, license manifest will be skipped

@ricardosalveti
Copy link
Member

What causes the image manifest to not be generated?

@quaresmajose
Copy link
Member Author

Good question, it could be that it is generated with a different name but I don't know.
In the lmp-base distro this happens.

@quaresmajose
Copy link
Member Author

instead of having a message we can make this an error and so it becomes clearer what happened.

@ricardosalveti
Copy link
Member

We had working lmp-base ci runs before as well, which is why the question.

@quaresmajose
Copy link
Member Author

I will debug it more to get the reason.

@quaresmajose quaresmajose marked this pull request as draft October 1, 2024 16:16
Signed-off-by: Jose Quaresma <[email protected]>
Skip the loop if image manifest not found, instead of failing blindly.
Also show some status about not found license manifests.

Fix the following:

| + for img in ${DEPLOY_DIR_IMAGE}/*${MACHINE}.manifest
| ++ basename '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest'
| ++ sed -e s/.manifest//
| + image_name='*intel-corei7-64'
| ++ readlink '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest'
| ++ sed -e 's/\..*manifest//'
| + image_name_id=
| Script completed with error(s)

Signed-off-by: Jose Quaresma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants