-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lmp/bb-config: use variables instead of the content #311
Conversation
@@ -195,14 +195,17 @@ fi | |||
|
|||
# Add build id H_BUILD to output files names | |||
if [ "$CONF_VERSION" == "1" ]; then | |||
cat << EOFEOF >> conf/local.conf | |||
DISTRO_VERSION_append = "-\${H_BUILD}-\${LMP_VERSION}" | |||
cat << 'EOFEOF' >> conf/local.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 'EOFEOF' to not evaluate the variable when writing conf/local.conf
Don't we need to change bitbake to allow these env variables to be consumed as well? |
BB_ENV_PASSTHROUGH or similar. |
just a note: to avoid rewriting a default |
BB_ENV_PASSTHROUGH is not needed in this case because all the varaibles needed is already defined in local.conf. For example:
With this patch it will show that there are differences in all the variables as in previoes but the root cause of the cache signature change it's just the variable |
5f8977f
to
12abd92
Compare
The main intention is to facilitate debugging issue in the sstate-cache, there is no functionality changes in this PR and this only affects the bitbake cache signatures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add this note to the PR description. |
done |
12abd92
to
4366596
Compare
Let's let bitbake take care of the use of the variables: LMP_FACTORY_IMAGE OSTREE_BRANCHNAME GARAGE_TARGET_VERSION GARAGE_TARGET_URL DISTRO_VERSION All of then have references for other variables: MACHINE H_BUILD LMP_VERSION Signed-off-by: Jose Quaresma <[email protected]>
This contain the extended version used on CI and with this new variable we make it possible to override it when needed. Signed-off-by: Jose Quaresma <[email protected]>
4366596
to
6cf0d16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can land tomorrow morning to avoid possible issues when we're not around.
Please note I don't have privileges to merge this repo |
Let's let bitbake take care of the use of the variables:
All of then have references for other variables:
BB_ENV_PASSTHROUGH
is not needed in this case because all the varaibles needed is already defined in local.conf.The main reason for this change is to let bitbake track and show what have changed in the cache signatureres.
For example:
When the
H_BUILD
change, bitbake will show diferences in all variable that is using theH_BUILD
somehow and root cause of the cache signature change it's the change of all the afected variables:With this patch it will show that there are differences in all the variables as in previoes but the root cause of the cache signature change it's just the variable
H_BUILD
.