Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmp/build.sh: create bitbake_buildchart.svg with the buildstats collected data [V2] #296

Merged
merged 2 commits into from
Aug 2, 2023
Merged

lmp/build.sh: create bitbake_buildchart.svg with the buildstats collected data [V2] #296

merged 2 commits into from
Aug 2, 2023

Conversation

quaresmajose
Copy link
Member

@quaresmajose quaresmajose commented Aug 1, 2023 •
edited
Loading

First version of this PR #286 have a bug because it uses bitbake-getvar that it is not avaliable before kirkstone so it was reverted:

The commit 199c61d adress the issue and will check if bitbake-getvar is available.

@quaresmajose quaresmajose requested a review from a team August 1, 2023 08:39
@quaresmajose
Copy link
Member Author

quaresmajose commented Aug 1, 2023 •
edited
Loading

Tested in my factory on the main/kirksone branch

image

@ricardosalveti
Copy link
Member

Can you squash the first 2 commits?

Also, maybe we should rename the final svg file to something that is easier to understand for the common user? Bootchart might give the wrong impression that this is related to the boot process and not the OE build.

Please also expose that file under the other folder, otherwise it will show at the top level (since this file is not critical to the user).

@quaresmajose
lmp/bb-build: check first if the buildstats was enabled
199c61d 
Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose
lmp/bb-build: create bitbake_buildchart.svg with the buildstats colle…
a144dfb 
…cted data

In LmP build we have the buildstats enabled because we use the
INHERIT += "buildstats" but the output is hard to read and understand.
The openembedded-core pybootchartgui scripts can process this logs and
generates some pretty charts.

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose quaresmajose changed the title lmp/build.sh: create bootchart.svg with the buildstats collected data [V2] lmp/build.sh: create bitbake_buildchart.svg with the buildstats collected data [V2] Aug 1, 2023
@quaresmajose
Copy link
Member Author

Can you squash the first 2 commits?

done

Also, maybe we should rename the final svg file to something that is easier to understand for the common user? Bootchart might give the wrong impression that this is related to the boot process and not the OE build.

file renamed to bitbake_buildchart.svg

Please also expose that file under the other folder, otherwise it will show at the top level (since this file is not critical to the user).

also moved to other folder

ricardosalveti
ricardosalveti approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just doing some testing locally first.

igoropaniuk
igoropaniuk approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@igoropaniuk igoropaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit d62f564 into foundriesio:master Aug 2, 2023
1 check passed
@quaresmajose quaresmajose deleted the buildstats branch August 8, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCry0 MrCry0 MrCry0 approved these changes

@igoropaniuk igoropaniuk igoropaniuk approved these changes

@ricardosalveti ricardosalveti ricardosalveti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quaresmajose @ricardosalveti @MrCry0 @igoropaniuk