Handle uri with tags #288
Merged
Handle uri with tags #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
force-pushed
the
handle-uri-with-tags
branch
from
f307686
to
c9a947e
Compare
doanac
reviewed
Jul 17, 2023
mike-sul
force-pushed
the
handle-uri-with-tags
branch
from
c9a947e
to
6a4db0b
Compare
A user may refer to images build and stored by Fio with a tag, e.g. `latest`. This fix takes it into account. Signed-off-by: Mike <[email protected]>
mike-sul
force-pushed
the
handle-uri-with-tags
branch
from
6a4db0b
to
28e854d
Compare
A user may refer to a factory image with a pinned/sha256 digest in `docker-compose.yml`. It implies that the given image is not built in the current CI run, hence the image is not analyzed by the SBOM logic for images built in the current CI run. This change makes the SBOM logic for non-factory images pull the pinned factory images, thus all App's images are SBOMed. Signed-off-by: Mike <[email protected]>
mike-sul
force-pushed
the
handle-uri-with-tags
branch
from
28e854d
to
e3c8526
Compare
Signed-off-by: Mike <[email protected]>
doanac
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix to handle image URIs with tag for images built by the Fio CI.