This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
Avoid hiding and keeping track of private windows #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thank you. Sounds reasonable. Could you add a pref for that (can't think of an obvious name right now) ? See 0f28d23 for how to do it. |
| @@ -18,6 +18,29 @@ var firetrayChrome = { // each new window gets a new firetrayChrome ! | |||
| winId: null, | |||
|
|
|||
| onLoad: function(win) { | |||
| try { | |||
| // Firefox 20+ | |||
| Components.utils.import("resource://gre/modules/PrivateBrowsingUtils.jsm"); | |||
There was a problem hiding this comment.
Nit: Components.utils aliased to Cu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids adding the firetray Handler to windows that are private. This makes it so that when a user is surfing privately and exits the window it is not kept. Which would allow other users of the same machine to see the users session, which defeats the purpose of a private session.