Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1492: create enum for all theme types' #1494

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

sakshee-19
Copy link
Contributor

Fixes #1492

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • Added single configuration for all theme types.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #1494 into development will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1494      +/-   ##
===============================================
+ Coverage         63.4%   63.45%   +0.05%     
===============================================
  Files               51       52       +1     
  Lines             1451     1453       +2     
  Branches           181      181              
===============================================
+ Hits               920      922       +2     
+ Misses             423      420       -3     
- Partials           108      111       +3
Impacted Files Coverage Δ
src/app/types/theme.ts 100% <100%> (ø)
src/app/theme/theme.component.ts 90.62% <50%> (+0.09%) ⬆️
src/app/intelligence/intelligence.component.ts 76% <0%> (-8%) ⬇️
src/app/services/intelligence.service.ts 83.33% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2998f5...d01347e. Read the comment docs.

Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakshee-19 we can also convert other hard-coded enums/types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create enum for theme types
2 participants