Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #58 implementation of image search for google #73

Closed
wants to merge 3 commits into from

Conversation

nikhilrayaprolu
Copy link
Member

Address #58 implemented image scraper for google
image
@mariobehling please review

@ghost ghost added the needs-review label Aug 7, 2017
@ghost ghost assigned nikhilrayaprolu Aug 7, 2017
@nikhilrayaprolu
Copy link
Member Author

@enigmaeth please review.

@afrozas
Copy link
Contributor

afrozas commented Aug 10, 2017

All the four buttons look crowded. Can you change them to maybe a dropdown list or something else?
@niranjan94 views?

Plus please squash the commits here and in other PRs as well.

@niranjan94
Copy link
Member

niranjan94 commented Aug 11, 2017

Instead of text, have symbols/icons and show the text in a tooltip.

{ } - json
< /> - xml
txt - Text
<a camera/photo icon> - image

@mariobehling
Copy link
Member

I am closing this due to inactivity.

@ghost ghost added invalid and removed needs-review labels Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants