Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

505 mock issue #536

Closed
wants to merge 6 commits into from
Closed

505 mock issue #536

wants to merge 6 commits into from

Conversation

impiyush83
Copy link

Fixes #505

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #536 into master will decrease coverage by 0.18%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   91.85%   91.66%   -0.19%     
==========================================
  Files          30       30              
  Lines         896      900       +4     
==========================================
+ Hits          823      825       +2     
- Misses         73       75       +2
Impacted Files Coverage Δ
app/scrapers/generalized.py 85.5% <50%> (-2.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfa3e2...089f4a2. Read the comment docs.

@impiyush83 impiyush83 closed this Sep 24, 2018
@impiyush83 impiyush83 deleted the 505-mock-issue branch September 24, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dailymotion scrapper is not working properly.
1 participant