Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #464 Add Image search support of Yahoo #465

Closed
wants to merge 1 commit into from

Conversation

bhaveshAn
Copy link
Member

Fixes #464
Addresses #321

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Added Image search support of Yahoo

Providing heroku deployment at https://mysterious-forest-53910.herokuapp.com/
@mariobehling @vaibhavsingh97 @ParthS007 Please review. Thanks !!

@Remorax
Copy link
Contributor

Remorax commented Jan 22, 2018

I already made a PR 3-4 days back @bhaveshAn. Can this be closed? Thanks 😄

@bhaveshAn
Copy link
Member Author

then just reference the issue 464 in your PR in title and PR desc

@bhaveshAn bhaveshAn closed this Jan 22, 2018
@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #465 into master will decrease coverage by 1.87%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   89.15%   87.28%   -1.88%     
==========================================
  Files          28       28              
  Lines         664      684      +20     
==========================================
+ Hits          592      597       +5     
- Misses         72       87      +15
Impacted Files Coverage Δ
app/server.py 84.88% <100%> (+0.17%) ⬆️
app/scrapers/generalized.py 75% <11.11%> (-11.28%) ⬇️
app/scrapers/yahoo.py 65.9% <25%> (-9.1%) ⬇️
app/scrapers/__init__.py 92.3% <50%> (-3.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2198d5...f16d32e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Image search support of Yahoo
2 participants