Fixes #462 Add Video search support for Ask #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 87.5% 85.39% -2.11%
==========================================
Files 28 28
Lines 720 760 +40
==========================================
+ Hits 630 649 +19
- Misses 90 111 +21
Continue to review full report at Codecov.
|
|
Added tests at |
cclauss
approved these changes
Jan 23, 2018
ParthS007
approved these changes
Jan 25, 2018
|
@vaibhavsingh97 Please review asap... |
rohitsainicool
approved these changes
Jan 26, 2018
|
Please resolve conflicts |
gabru-md
suggested changes
Jan 26, 2018
app/scrapers/__init__.py
Outdated
| @@ -42,6 +42,8 @@ def feed_gen(query, engine, count=10, qtype=''): | |||
| engine = old_names.get(engine, engine) | |||
| if engine in ('quora', 'youtube'): | |||
| urls = scrapers[engine].search_without_count(query) | |||
| elif engine in ('ask',) and qtype == 'vid': | |||
There was a problem hiding this comment.
Why use in ('ask',)
You can go with if engine == 'ask'
since there is only one option to choose from?
There was a problem hiding this comment.
So that other engines can also be added in this tuple, if there implementation is same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
Addresses #320
Checklist
masterbranch.Changes proposed in this pull request:
Providing the heroku deployment at https://salty-spire-70237.herokuapp.com/
@mariobehling @ParthS007 @vaibhavsingh97 Please review. Thanks !!