video-search : google #426
Conversation
| response = requests.get(self.url, headers=self.headers, params=payload) | ||
| print(response.url) |
There was a problem hiding this comment.
Well that was during testing. I forgot to remove it 😅
I don't know about live link. Can you tell me more?
There was a problem hiding this comment.
@umangahuja1 Deploy it on heroku and share the link here
There was a problem hiding this comment.
I am not able to deploy. It is asking for card details. Though I have deployed my apps for free earlier.
|
@umangahuja1 Good Job 🎉 |
|
@vaibhavsingh97 we can also do it one search engine at a time. |
|
Can you please share a link to test, or screenshots at least? Thank you 😄 |
|
I have sent one in issues. If you want I can send another of the query you wish. |
|
We actually want to test it via link.
If the PR is ready for review than please share heroku deployment to get it
reviewed quickly.
…On Jan 14, 2018 1:49 PM, "Umang Ahuja" ***@***.***> wrote:
I have sent one in issues. If you want I can send another of the query you
wish.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#426 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV37-oVHOPV_8vtzpyYgnHPZNYkPQjzlks5tKbiIgaJpZM4RVNXI>
.
|
|
I don't know why but heroku is asking for card details. It has never happened before. Can anybody brief about it? |
|
Check out in your Heroku dashboard, you might have used 5 free apps.
…On Jan 14, 2018 2:02 PM, "Umang Ahuja" ***@***.***> wrote:
I don't know why but heroku is asking for card details. It has never
happened before. Can anybody brief about it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#426 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV37-r8aq2fzfsIk4146K6mxsJyikyTWks5tKbuNgaJpZM4RVNXI>
.
|
|
No just 2 of them. And it's due to the mongodb add-on. |
|
So remove the add-on if it restricting you to make more apps.
However, in the recent merge we have disabled mongo. I suppose.
…On Jan 14, 2018 2:08 PM, "Umang Ahuja" ***@***.***> wrote:
No just 2 of them. And it's due to the mongodb add-on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#426 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV37-jhh1kmi4h7yaDfKdJ4Y2TGraXz_ks5tKbzxgaJpZM4RVNXI>
.
|
|
If that's the case I can rebase the branch and it will do the job. |
|
Are you able to create the app? |
|
Also, since now we have divided the Issue. So please write And same in the PR Ttitle as well. Follow best practices. |
|
Here is the link to the deployed app : https://my-query-server.herokuapp.com/ |
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 46.98% 47.26% +0.27%
==========================================
Files 17 17
Lines 398 402 +4
==========================================
+ Hits 187 190 +3
- Misses 211 212 +1
Continue to review full report at Codecov.
|
Fixes #320
Checklist
masterbranch.Changes proposed in this pull request: