Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No option to search images #321

Open
1 of 2 tasks
vaibhavsingh97 opened this issue Nov 8, 2017 · 11 comments
Open
1 of 2 tasks

No option to search images #321

vaibhavsingh97 opened this issue Nov 8, 2017 · 11 comments
Assignees
@vaibhavsingh97
Labels
enhancement

Comments

@vaibhavsingh97
Copy link
Member

With reference to #58

I'm submitting a ...

  • bug report
  • feature request

Current behavior:
There is no option to search images in Search engines

Expected behavior:
There should be option to search images and videos
@ParthS007
Copy link
Member

I want to work on this.

@ParthS007
Copy link
Member

working on it

@ParthS007 ParthS007 self-assigned this Nov 16, 2017
@vaibhavsingh97 vaibhavsingh97 mentioned this issue Nov 27, 2017
Open
@raju249
Copy link
Contributor

raju249 commented Dec 2, 2017

Hey @ParthS007 ,
Can I take this if its available ?

@raju249
Copy link
Contributor

raju249 commented Dec 2, 2017

I guess you working on fossasia/badgeyay#383

So I am claiming this 😃

@raju249
Copy link
Contributor

raju249 commented Dec 2, 2017

PR on its way!! 😊

@raju249
Copy link
Contributor

raju249 commented Dec 2, 2017 •
edited
Loading

Which all engines should be supported for image search ?
I am thinking of adding Google for first.
Let me know what you guys think.

@ParthS007
Copy link
Member

@raju249 I have done work on it but not able to complete my work due to my university exams. I will make PR as soon as my exams are over. I think you can understand.

@raju249
Copy link
Contributor

raju249 commented Dec 2, 2017

Hey, I am so sorry. I thought it's been 18 days..so may be you got busy with other stuff.
Anyways, you can continue working on this.
No problem.
I backing off 😊

@dgarvit
Copy link
Contributor

dgarvit commented Dec 13, 2017

@ParthS007 are you still working? I would like to work on this in case you are not. 😄

@vaibhavsingh97
Copy link
Member Author

Working on it

@bhaveshAn bhaveshAn mentioned this issue Jan 2, 2018
Closed
3 tasks
@ParthS007 ParthS007 removed their assignment Jan 2, 2018
@bhaveshAn bhaveshAn mentioned this issue Jan 2, 2018
Open
2 tasks
@vaibhavsingh97 vaibhavsingh97 mentioned this issue Jan 6, 2018
Closed
3 tasks
@vaibhavsingh97 vaibhavsingh97 self-assigned this Jan 6, 2018
Remorax pushed a commit to Remorax/query-server that referenced this issue Jan 14, 2018
@yashLadha @ParthS007
Corrected susi logo (fossasia#320)
abeba57 
Fixes fossasia#321

Signed-off-by: yashLadha <[email protected]>
@Remorax
Copy link
Contributor

Remorax commented Jan 19, 2018

I would like to add Yahoo image search, I just made a PR for Yahoo video search and its not difficult to add image search from there. Hope that's fine 😄

bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 19, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
cc27c34 
…t for Bing
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 19, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
b6849c5 
…t for Bing
@bhaveshAn bhaveshAn mentioned this issue Jan 19, 2018
Merged
3 tasks
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 20, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
8448d60 
…t for Parsijoo
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 20, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
62e7735 
…t for Parsijoo
@bhaveshAn bhaveshAn mentioned this issue Jan 20, 2018
Merged
3 tasks
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 20, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
aa55eca 
…t for Parsijoo
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 20, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
5b60b9f 
…t for Parsijoo
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 20, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
70899f8 
…t for Parsijoo
bhaveshAn added a commit to bhaveshAn/query-server that referenced this issue Jan 20, 2018
@bhaveshAn
Addresses fossasia#320 and fossasia#321 Add Image/Video search suppor…
946781a 
…t for Bing
This was referenced Jan 21, 2018
Closed
Closed
Closed
@Remorax Remorax mentioned this issue Jan 22, 2018
Merged
3 tasks
mariobehling pushed a commit that referenced this issue Jan 26, 2018
@bhaveshAn @mariobehling
Fixes #456 Add Image/Video search support for Bing (#448)
bd30392 
* Addresses #320 and #321 Add Image/Video search support for Bing

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Added tests

* Added tests

* Added tests

* Added tests

* Added tests
ParthS007 pushed a commit that referenced this issue Jan 28, 2018
@Remorax @ParthS007
Addresses #321 Fixes #464 Adds image search support for Yahoo (#447)
4cdffca 
* Added Yahoo image search

Fixed travis

Squashed the commits

* Added tests

* Fixed codacy and travis

* Added staticmethod, removed self argument
mariobehling pushed a commit that referenced this issue Jan 29, 2018
@bhaveshAn @mariobehling
Fixes #455 Add Image/Video search support for Parsijoo (#449)
70a7e96 
* Addresses #320 and #321 Add Image/Video search support for Parsijoo

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add staticmethod decorator

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaibhavsingh97 vaibhavsingh97

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Added images support vaibhavsingh97/query-server
5 participants
@raju249 @vaibhavsingh97 @ParthS007 @dgarvit @Remorax