Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue WDS in error log console #146

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Fix issue WDS in error log console #146

merged 2 commits into from
Jul 5, 2024

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Jul 4, 2024 •
edited
Loading

This PR have some changes as below:

  • Fix issue WDS in error log console.
  • Add CORS in whitelist for of server service.
  • Based on the Protocol, use http or https for connection from webapp to server

odkhang added 2 commits July 4, 2024 15:30
@odkhang
fix issue error log with wds
e3132d1 
add cors whitelist for server
based on the protocal, use http/https for communication webapp to server
@odkhang
update cors whitelist
64074a4
@odkhang odkhang requested review from marcoag and mariobehling July 4, 2024 08:32
@hongquan
Copy link
Member

hongquan commented Jul 5, 2024

Please captialize the beginning of you PR title. Those are for human to read, need to be applied grammar, spelling rule as in school.

@odkhang odkhang changed the title fix issue error log with wds Fix issue WDS in error log console Jul 5, 2024
@mariobehling mariobehling merged commit 214a782 into fossasia:development Jul 5, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@marcoag marcoag Awaiting requested review from marcoag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odkhang @hongquan @mariobehling