Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual of how many people are watching in each room #134

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Jul 2, 2024

Fixes #111 Add visual of how many people are watching in each room

Short description of what this resolves:

Add visual of how many people are watching in each room

Changes proposed in this pull request:

  • Add visual of how many people are watching in each room

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@lcduong lcduong marked this pull request as ready for review July 2, 2024 10:08
@mariobehling
Copy link
Member

Thanks, please add screeshots here.

@odkhang
Copy link
Collaborator

odkhang commented Jul 8, 2024

hi @mariobehling, please find below for a screenshot
image

@mariobehling
Copy link
Member

Nice! We need to make sure that these numbers also work when people switch across different languages.

@mariobehling mariobehling requested review from hongquan and untari July 8, 2024 12:25
Copy link
Contributor

@untari untari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-07-08 22-56-55

I cherry-pick the changes and test it locally, and the feature works fine it shows how many people watching in real-time

@mariobehling mariobehling self-requested a review July 10, 2024 16:21
@mariobehling mariobehling merged commit 2eebf4d into fossasia:development Jul 10, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual of how many people are watching in each room
4 participants