Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect value for request.includeType #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kketch
Copy link
Member

@kketch kketch commented Jul 12, 2021

This addresses a race condition when fortune is running hooks for included types, by cloning the request context for each included type.
Currently the request object is shared among concurrent promises and might hold an incorrect value for includeType if we're fetching multiple relationships

@kketch kketch force-pushed the master branch 2 times, most recently from c4c85ab to 26c53a1 Compare July 12, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant