-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove msys
from CI and install fypp
via msys2 package
#854
Conversation
@minhqdao, thank you for your sharing. As far as I know, I have been a user of It is sufficient for |
I see, it was probably not the best idea to merge the two setups then – I can revert that. In fact, the idea for this PR was only to fix the setup for |
Ok, I see it was |
fypp
via msys2 packagemsys
from CI and install fypp
via msys2 package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minhqdao, thanks, LGTM.
Will merge this so the CI stops failing. If there's ever the need to bring back |
msystem: msys
from CI.fypp
via msys2 package instead ofpip
.Address #853.