Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reverse from stdlib_ascii to stdlib_strings #745

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Pranavchiku
Copy link

@Pranavchiku Pranavchiku commented Nov 2, 2023

When I build, it throws me following error, I am not sure why it happens:

% cmake --build build                             
[ 19%] Built target fortran_stdlib
[ 19%] Built target test-drive-lib
[ 19%] Built target test_always_skip
[ 20%] Built target test_always_fail
[ 21%] Built target test-drive-tester
[ 22%] Built target test_logicalloc
[ 22%] Built target test_ascii
[ 22%] Built target test_stdlib_bitset_64
[ 23%] Built target test_stdlib_bitset_large
[ 24%] Built target test_hash_functions
[ 24%] Built target test_32_bit_hash_performance
[ 24%] Built target test_64_bit_hash_performance
[ 25%] Built target test_chaining_maps
[ 25%] Built target test_open_maps
[ 25%] Built target test_maps
[ 25%] Built target test_loadtxt
[ 25%] Built target test_savetxt
[ 25%] Built target test_loadtxt_qp
[ 25%] Built target test_savetxt_qp
[ 25%] Built target test_getline
[ 26%] Built target test_npy
[ 26%] Built target test_open
[ 26%] Built target test_parse_mode
[ 26%] Built target test_linalg
[ 26%] Built target test_linalg_matrix_property_checks
[ 26%] Built target test_stdlib_logger
[ 27%] Built target test_optval
[ 28%] Built target test_selection
[ 29%] Built target test_sorting
[ 29%] Built target test_specialfunctions_gamma
[ 29%] Built target test_corr
[ 29%] Built target test_cov
[ 30%] Built target test_mean
[ 30%] Built target test_median
[ 30%] Built target test_moment
[ 31%] Built target test_rawmoment
[ 31%] Built target test_var
[ 32%] Built target test_varn
[ 32%] Built target test_random
[ 33%] Built target test_distribution_uniform
[ 33%] Built target test_distribution_normal
[ 34%] Built target test_distribution_exponential
[ 35%] Built target test_string_assignment
[ 35%] Built target test_string_operator
[ 35%] Built target test_string_intrinsic
[ 36%] Built target test_string_match
[ 36%] Built target test_string_derivedtype_io
[ 36%] Building Fortran object test/string/CMakeFiles/test_string_functions.dir/test_string_functions.f90.o
/Users/pranavchiku/repos/stdlib-fortran-lang/test/string/test_string_functions.f90:93:26:

   93 |         call check(error, reverse(test_string) == compare_string)
      |                          1
Error: There is no specific function for the generic 'reverse' at (1)
/Users/pranavchiku/repos/stdlib-fortran-lang/test/string/test_string_functions.f90:717:9:

  717 |     use test_string_functions, only : collect_string_functions
      |         1
Fatal Error: Cannot open module file 'test_string_functions.mod' for reading at (1): No such file or directory
compilation terminated.
make[2]: *** [test/string/CMakeFiles/test_string_functions.dir/test_string_functions.f90.o] Error 1
make[1]: *** [test/string/CMakeFiles/test_string_functions.dir/all] Error 2
make: *** [all] Error 2

cc @awvwgk @ivan-pi

@jvdp1
Copy link
Member

jvdp1 commented Nov 2, 2023

This is strange. Which compiler do you use?

@Pranavchiku
Copy link
Author

Which compiler do you use?

GFortran

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a regression in functionality by removing the support for string_type.

@jvdp1
Copy link
Member

jvdp1 commented Nov 4, 2023

I don't think that this PR is the appropriate solution to the observed issue, but I have no clue what the problem could be. What the original module including reverse appropriately compiled?

@Pranavchiku
Copy link
Author

Pranavchiku commented Nov 4, 2023

Okay, what will be a way to get the issue fixed?

@jvdp1
Copy link
Member

jvdp1 commented Nov 19, 2023

Okay, what will be a way to get the issue fixed?

It seems that there is an issue with dependencies, maybe with cmake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants