mask_mean_dev: addition of a mask in mean API #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Jan 29, 2020
|
@jvdp1 Sure. Actually, now it seems to be possible to select me as reviewer. I'll try to have a detailed look at it tomorrow. |
aradi
approved these changes
Feb 1, 2020
There was a problem hiding this comment.
I am absolutely fine with the changes.
As a side note: It is horrifying, that in order to introduce the mask, we had to double the already very high number of functions, but I don't see any other possibility. If we provide a lot of generic functions like this, it could get out of hand at some point.
|
Thank you @aradi for the review. @milancurcic could you have a last look and merge it if you are happy with the proposed changes? |
milancurcic
approved these changes
Feb 1, 2020
|
Great work, thanks @jvdp1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maskin the API ofmean, as discussed in Addition of a mask to stdlib_experimental_stats functionmean#128.NaNreturns are based onieee_arithmetic;integerarray was not converted toreal(dp)before doing thesum(were our tests not severe enough for these scenarions?).@aradi : I can't request you as reviewer (the system doesn't find you). Could you have also a look, please?