Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTE-370] Generate valid xfrm when required #694

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

raoulstrackx
Copy link
Contributor

There are two issues with running SGX enclaves on Sapphire Rapids:

  • When running debug enclaves, we used to use XCR0 unmodified for the xfrm attribute. But now advanced matrix extensions (AMX) may lead to larger SSA frames (3 pages) than expected. The elf2sgxs tool by default only selected 1 page for SSA frames. When generating a signature, we need to ensure features are turned off when they would lead to larger SSA frames.
  • Turning features off, may conflict with one another. XTILECFG and XTILEDATA need to be either enabled both, or disabled both. This PR sets the xfrm attribute accordingly.

Address #565

@raoulstrackx raoulstrackx force-pushed the raoul/rte-370-generate_correct_xfrm_on_sapphire_rapids branch from c530abd to 32ac7f7 Compare February 17, 2025 13:29
@raoulstrackx raoulstrackx changed the title Generate valid xfrm when required [RTE-370] Generate valid xfrm when required Feb 17, 2025
@raoulstrackx raoulstrackx force-pushed the raoul/rte-370-generate_correct_xfrm_on_sapphire_rapids branch from 1600aae to 61fb9d1 Compare February 19, 2025 14:22
jethrogb
jethrogb previously approved these changes Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants