Update dcap-artifact-retrieval PCCS provider tests #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzohreva
previously approved these changes
Feb 4, 2025
- load url from env for pccs provider test - run these tests only when env val is provided
Taowyoo
force-pushed
the
yx/setup_pccs_test
branch
from
f9a5b9f to
2d035c3
Compare
s-arash
reviewed
Feb 6, 2025
| static PCCS_URL: OnceLock<String> = OnceLock::new(); | ||
|
|
||
| fn pccs_url_from_env() -> String { | ||
| let api_key = std::env::var("PCCS_URL").expect("PCCS_URL must be set"); |
There was a problem hiding this comment.
Is the api_key name appropriate?
There was a problem hiding this comment.
good catch will fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCCS_URL.