Fix the ImportWorker (#61)

* Fix the ImportWorker
* Move start date to model

app/models/payment_history.rb

@@ -151,6 +151,10 @@ class PaymentHistory < ActiveRecord::Base
   validates :user_id, presence: true
 
   class << self
+    def default_start_date
+      4.years.ago.to_date
+    end
+
     def import_csv(current_user, last_calculated_metric_date, filename)
       temp = Tempfile.new("import")
       s3 = Aws::S3::Client.new
@@ -349,7 +353,7 @@ def calculate_metrics(current_user)
       elsif current_user.payment_histories.any?
         current_user.payment_histories.order("payment_date").first.payment_date
       else
-        6.months.ago.to_date
+        PaymentHistory.default_start_date
       end
       Rails.logger.info(calculate_from)
       last_imported_payment = current_user.payment_histories.maximum(:payment_date)

app/workers/import_worker.rb

@@ -8,12 +8,12 @@ def self.perform(current_user_id, filename = nil)
     return unless current_user_id
 
     current_user = User.find(current_user_id)
-    last_calculated_metric = current_user.newest_metric_date || 48.months.ago.to_date
+    last_calculated_metric = current_user.newest_metric_date || PaymentHistory.default_start_date
 
     if !filename.nil?
-      PaymentHistory.import_csv(current_user, last_calculated_metric_date, filename)
+      PaymentHistory.import_csv(current_user, last_calculated_metric, filename)
     else
-      PaymentHistory.import_partner_api(current_user, last_calculated_metric_date)
+      PaymentHistory.import_partner_api(current_user, last_calculated_metric)
     end
 
     # Payments must be imported fully before metrics can be calculated