-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support submit errors and error message upon submitting a form #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, but let's change the approach.
Ideally those should live in the form and not the individual fields since submit errors won't exist unless the field is part of a form. It also would allow querying those errors on the form-level which might be desired.
So I imagine building the submit errors as a similar state to the errors
we already have on the form and fields just expose them via a computed property. There is still the weird case of the search field but let's tackle that later.
Let's add tests and a changeset and this would be good to go!
🦋 Changeset detectedLatest commit: 205c43e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2287c5e
to
00000a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor changes to comments for the doc generation.
commit: |
No description provided.