Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve playground and watch scripts #75

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

logaretm
Copy link
Member

@logaretm logaretm commented Nov 23, 2024

What

The watch script broke down a while ago, changes are not reflected in all output bundles and is generating unwanted files during the watch process in the dist which can be published by mistake.

The scripting files also weren't typed.

How

This fixes the issues noticed there:

  • By orchestrating the tsconfig into 2 files, one for scripts/tests and any node related scripting, another for the lib with no access to the Node runtime API.
  • Re-writing the watch script to produce all 3 types of modules.
  • Removing formwerk from optimized deps to ensure the watcher output is being used.

Copy link

changeset-bot bot commented Nov 23, 2024

⚠️ No Changeset found

Latest commit: b24384f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@logaretm logaretm merged commit 4075936 into main Nov 23, 2024
3 checks passed
@logaretm logaretm deleted the chore/build-and-watch-fixes branch November 23, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant