feat: rename popup props to listbox props

formwerkjs · Jan 11, 2025 · 9ac6e68 · 9ac6e68
1 parent 4ccd4fd
commit 9ac6e68
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/core/src/useComboBox/useComboBox.ts b/packages/core/src/useComboBox/useComboBox.ts
@@ -275,7 +275,7 @@ export function useComboBox<TOption, TValue = TOption>(_props: Reactivify<ComboB
        */
       errorMessageProps,
       /**
-       * Props for the listbox element.
+       * Props for the listbox/popup element.
        */
       listBoxProps,
       /**

diff --git a/packages/core/src/useSelect/useSelect.spec.ts b/packages/core/src/useSelect/useSelect.spec.ts
@@ -51,7 +51,7 @@ function createSelect() {
       const {
         labelProps,
         triggerProps,
-        popupProps,
+        listBoxProps,
         errorMessageProps,
         descriptionProps,
         displayError,
@@ -73,7 +73,7 @@ function createSelect() {
         fieldValue,
         labelProps,
         triggerProps,
-        popupProps,
+        listBoxProps,
         errorMessageProps,
         descriptionProps,
         displayError,
@@ -92,7 +92,7 @@ function createSelect() {
             {{ fieldValue || 'Select here' }}
           </div>
 
-          <div v-bind="popupProps" popover>
+          <div v-bind="listBoxProps" popover>
             <slot>
               <template v-if="groups">
                 <OptionGroup v-for="group in groups" :key="group.label" :label="group.label">

diff --git a/packages/core/src/useSelect/useSelect.ts b/packages/core/src/useSelect/useSelect.ts
@@ -279,9 +279,9 @@ export function useSelect<TOption, TValue = TOption>(_props: Reactivify<SelectPr
        */
       labelProps,
       /**
-       * Props for the popup element.
+       * Props for the listbox/popup element.
        */
-      popupProps: listBoxProps,
+      listBoxProps,
       /**
        * Props for the error message element.
        */