Skip to content

Commit

Permalink
fix: add aria hidden as well
Browse files Browse the repository at this point in the history
  • Loading branch information
logaretm committed Jan 16, 2025
1 parent ef9c737 commit 491816e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions packages/core/src/useOption/useOption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ interface OptionDomProps {
'aria-checked'?: boolean;
'aria-disabled'?: boolean;
hidden?: boolean;
'aria-hidden'?: boolean;

style?: CSSProperties;
}
Expand Down Expand Up @@ -138,6 +139,7 @@ export function useOption<TOption>(_props: Reactivify<OptionProps<TOption>>, ele

if (isHidden.value) {
domProps.hidden = true;
domProps['aria-hidden'] = true;
domProps.style = {
display: 'none',
};
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/components/ComboBox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const props = defineProps<Props>();
const { contains } = useDefaultFilter({
caseSensitive: false,
debounceMs: 200,
debounceMs: 300,
});
const { inputProps, listBoxProps, labelProps, buttonProps, errorMessageProps, errorMessage, descriptionProps } =
Expand Down

0 comments on commit 491816e

Please sign in to comment.