-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pickle support #1111
Add Pickle support #1111
Conversation
package.json
Outdated
@@ -22,7 +22,7 @@ | |||
"python", | |||
"perl", | |||
"ruby", | |||
"multi-root ready" | |||
"multi-root ready", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No extra ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied changes
package.json
Outdated
@@ -185,7 +185,8 @@ | |||
"fortran": "cd $dir && gfortran $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt", | |||
"sml": "cd $dir && sml $fileName", | |||
"mojo": "mojo run", | |||
"erlang": "escript" | |||
"erlang": "escript", | |||
"pickle": "pkl eval -f yaml $fileName -o $fileNameWithoutExt.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "pkl"
instead of "pickle"
, per https://github.com/apple/pkl-vscode/blob/66982961b84c3061c95fc8f4a889facdefccc637/package.json#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add cd $dir &&
, otherwise it will fail to find the file if file is not in root of the folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflict
package.json
Outdated
@@ -225,7 +226,8 @@ | |||
".ring": "ring", | |||
".sml": "cd $dir && sml $fileName", | |||
".mojo": "mojo run", | |||
".erl": "escript" | |||
".erl": "escript", | |||
".pkl": "pkl eval -f yaml $fileName -o $fileNameWithoutExt.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Add cd $dir &&
, otherwise it will fail to find the file if file is not in root of the folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied changes
Resolved conflicts. |
Support for Pickle
Closes #1099