Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pickle support #1111

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add Pickle support #1111

merged 2 commits into from
Apr 2, 2024

Conversation

vital987
Copy link
Contributor

Support for Pickle
Closes #1099

package.json Outdated
@@ -22,7 +22,7 @@
"python",
"perl",
"ruby",
"multi-root ready"
"multi-root ready",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No extra ,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied changes

package.json Outdated
@@ -185,7 +185,8 @@
"fortran": "cd $dir && gfortran $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt",
"sml": "cd $dir && sml $fileName",
"mojo": "mojo run",
"erlang": "escript"
"erlang": "escript",
"pickle": "pkl eval -f yaml $fileName -o $fileNameWithoutExt.yaml"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add cd $dir &&, otherwise it will fail to find the file if file is not in root of the folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied changes

Copy link
Owner

@formulahendry formulahendry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict

package.json Outdated
@@ -225,7 +226,8 @@
".ring": "ring",
".sml": "cd $dir && sml $fileName",
".mojo": "mojo run",
".erl": "escript"
".erl": "escript",
".pkl": "pkl eval -f yaml $fileName -o $fileNameWithoutExt.yaml"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Add cd $dir &&, otherwise it will fail to find the file if file is not in root of the folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied changes

@vital987
Copy link
Contributor Author

vital987 commented Apr 1, 2024

Resolved conflicts.

@vital987 vital987 requested a review from formulahendry April 1, 2024 16:02
@formulahendry formulahendry merged commit 992a45e into formulahendry:master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Pickle
2 participants