Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 17.1+ support #206

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Angular 17.1+ support #206

wants to merge 6 commits into from

Conversation

WingSMC
Copy link

@WingSMC WingSMC commented Jun 19, 2024 •
edited
Loading

Support for newer versions of Angular with signals & standalone component usage.

Notes

  • Updated docs, might need rewording
  • This prevents new versions of the package from working with older angular versions.
  • This also doesn't work with Angular v16, but people can write a 10 line wrapper.

resolves #145
closes #167

@vercel Vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auto-animate ❌ Failed (Inspect) Jun 19, 2024 1:15pm

@WingSMC WingSMC marked this pull request as draft June 19, 2024 12:58
@WingSMC WingSMC marked this pull request as ready for review June 19, 2024 13:07
@justin-schroeder justin-schroeder mentioned this pull request Jun 26, 2024
Open
@crazeidea
Copy link

any update on this?

@WingSMC
Copy link
Author

WingSMC commented Jul 26, 2024 •
edited
Loading

any update on this?

Someone needs to review it who knows angular. It could even be you.

As long as you are stuck here is a temporary solution

ajitzero
ajitzero approved these changes Nov 30, 2024
View reviewed changes
Copy link

@ajitzero ajitzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Aside: Have you looked at the main issue for Angular support (#72)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitzero ajitzero ajitzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 16 support add standalone directive for new angular
3 participants
@WingSMC @crazeidea @ajitzero