Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESTROY THE BUILDER #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ZenMasterJacob20011
Copy link
Contributor

Description

What changed?

When the formio-builder component is destroyed, call destroy on the builder instance to clean up memory

Why have you chosen this solution?

Let say you have some kind of app that navigates between forms and displays a builder to edit that form. When the app navigates to another form the angular formio-builder is destroyed but the webform from the builder is still referenced in Formio.forms. We need to make sure to call destroy on that builder instance so that a memory leak does not occure

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

Manually tested

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant