fix: asset format (#426)

fix: asset format (not allowing single char)
formancehq · Jan 31, 2023 · ef8f67b · ef8f67b
1 parent 5a72e81
commit ef8f67b
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/pkg/api/controllers/transaction_controller_test.go b/pkg/api/controllers/transaction_controller_test.go
@@ -626,6 +626,40 @@ func TestPostTransactions(t *testing.T) {
 				}},
 			},
 		},
+		{
+			name: "short asset",
+			payload: []controllers.PostTransaction{
+				{
+					Postings: core.Postings{
+						{
+							Source:      "world",
+							Destination: "bank",
+							Amount:      core.NewMonetaryInt(1000),
+							Asset:       "F/9",
+						},
+					},
+					Timestamp: timestamp3,
+				},
+			},
+			expectedStatusCode: http.StatusOK,
+			expectedRes: sharedapi.BaseResponse[[]core.ExpandedTransaction]{
+				Data: &[]core.ExpandedTransaction{{
+					Transaction: core.Transaction{
+						TransactionData: core.TransactionData{
+							Postings: core.Postings{
+								{
+									Source:      "world",
+									Destination: "bank",
+									Amount:      core.NewMonetaryInt(1000),
+									Asset:       "F/9",
+								},
+							},
+							Timestamp: timestamp3,
+						},
+					},
+				}},
+			},
+		},
 	}
 
 	internal.RunTest(t, fx.Invoke(func(lc fx.Lifecycle, api *api.API) {

diff --git a/pkg/core/asset.go b/pkg/core/asset.go
@@ -4,7 +4,7 @@ import (
 	"regexp"
 )
 
-var assetRegexp = regexp.MustCompile(`^[A-Z][A-Z0-9]{1,16}(\/\d{1,6})?$`)
+var assetRegexp = regexp.MustCompile(`^[A-Z][A-Z0-9]{0,16}(\/\d{1,6})?$`)
 
 func AssetIsValid(v string) bool {
 	return assetRegexp.Match([]byte(v))