Merge pull request #130 from numary/feature/property-checks

Add checks on source/destination/asset transaction properties.

pkg/core/asset.go

@@ -2,8 +2,8 @@ package core
 
 import "regexp"
 
-func AssetIsValid(v string) bool {
-	re := regexp.MustCompile("[A-Z]{1,8}")
+var assetRegexp = regexp.MustCompile("[A-Z]{1,16}(\\/\\d{1,6})?")
 
-	return re.Match([]byte(v))
+func AssetIsValid(v string) bool {
+	return assetRegexp.Match([]byte(v))
 }

pkg/core/posting.go

@@ -1,5 +1,7 @@
 package core
 
+import "regexp"
+
 type Posting struct {
 	Source      string `json:"source"`
 	Destination string `json:"destination"`
@@ -21,3 +23,9 @@ func (ps Postings) Reverse() {
 		ps[opp].Source, ps[opp].Destination = ps[opp].Destination, ps[opp].Source
 	}
 }
+
+var addressRegexp = regexp.MustCompile("^[a-zA-Z_0-9]+(:[a-zA-Z_0-9]+){0,}$")
+
+func ValidateAddress(addr string) bool {
+	return addressRegexp.Match([]byte(addr))
+}

pkg/ledger/ledger.go

@@ -84,6 +84,15 @@ func (l *Ledger) Commit(ctx context.Context, ts []core.Transaction) ([]core.Tran
 			if p.Amount < 0 {
 				return ts, NewValidationError("negative amount")
 			}
+			if !core.ValidateAddress(p.Source) {
+				return nil, NewValidationError("invalid source address")
+			}
+			if !core.ValidateAddress(p.Destination) {
+				return nil, NewValidationError("invalid destination address")
+			}
+			if !core.AssetIsValid(p.Asset) {
+				return nil, NewValidationError("invalid asset")
+			}
 			if _, ok := rf[p.Source]; !ok {
 				rf[p.Source] = map[string]int64{}
 			}