fix: from review

internal/storage/ledger/paginator.go

@@ -6,6 +6,6 @@ import (
 )
 
 type paginator[ResourceType any, PaginationOptions any] interface {
-	paginate(selectQuery *bun.SelectQuery, opts PaginationOptions) *bun.SelectQuery
+	paginate(selectQuery *bun.SelectQuery, opts PaginationOptions) (*bun.SelectQuery, error)
 	buildCursor(ret []ResourceType, opts PaginationOptions) (*bunpaginate.Cursor[ResourceType], error)
 }

internal/storage/ledger/paginator_column.go

@@ -18,7 +18,7 @@ type columnPaginator[ResourceType, OptionsType any] struct {
 }
 
 //nolint:unused
-func (o columnPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery, query ledgercontroller.ColumnPaginatedQuery[OptionsType]) *bun.SelectQuery {
+func (o columnPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery, query ledgercontroller.ColumnPaginatedQuery[OptionsType]) (*bun.SelectQuery, error) {
 
 	paginationColumn := o.defaultPaginationColumn
 	originalOrder := o.defaultOrder
@@ -57,7 +57,7 @@ func (o columnPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery
 		}
 	}
 
-	return sb
+	return sb, nil
 }
 
 //nolint:unused

internal/storage/ledger/paginator_offset.go

@@ -5,6 +5,7 @@ import (
 	"github.com/formancehq/go-libs/v2/bun/bunpaginate"
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 	"github.com/uptrace/bun"
+	"math"
 )
 
 type offsetPaginator[ResourceType, OptionsType any] struct {
@@ -13,7 +14,7 @@ type offsetPaginator[ResourceType, OptionsType any] struct {
 }
 
 //nolint:unused
-func (o offsetPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery, query ledgercontroller.OffsetPaginatedQuery[OptionsType]) *bun.SelectQuery {
+func (o offsetPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery, query ledgercontroller.OffsetPaginatedQuery[OptionsType]) (*bun.SelectQuery, error) {
 
 	paginationColumn := o.defaultPaginationColumn
 	originalOrder := o.defaultOrder
@@ -24,6 +25,9 @@ func (o offsetPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery
 	orderExpression := fmt.Sprintf("%s %s", paginationColumn, originalOrder)
 	sb = sb.ColumnExpr("row_number() OVER (ORDER BY " + orderExpression + ")")
 
+	if query.Offset > math.MaxInt32 {
+		return nil, fmt.Errorf("offset value exceeds maximum allowed value")
+	}
 	if query.Offset > 0 {
 		sb = sb.Offset(int(query.Offset))
 	}
@@ -32,7 +36,7 @@ func (o offsetPaginator[ResourceType, OptionsType]) paginate(sb *bun.SelectQuery
 		sb = sb.Limit(int(query.PageSize) + 1)
 	}
 
-	return sb
+	return sb, nil
 }
 
 //nolint:unused
@@ -54,6 +58,10 @@ func (o offsetPaginator[ResourceType, OptionsType]) buildCursor(ret []ResourceTy
 	// Page with transactions after
 	if query.PageSize != 0 && len(ret) > int(query.PageSize) {
 		cp := query
+		// Check for potential overflow
+		if query.Offset > math.MaxUint64-query.PageSize {
+			return nil, fmt.Errorf("offset overflow")
+		}
 		cp.Offset = query.Offset + query.PageSize
 		next = &cp
 		ret = ret[:len(ret)-1]

internal/storage/ledger/resource.go

@@ -114,7 +114,7 @@ func (r *resourceRepository[ResourceType, OptionsType]) validateFilters(builder
 				options := append([]string{property.name}, property.aliases...)
 				for _, option := range options {
 					if found, err = regexp.MatchString("^"+option+"$", key); err != nil {
-						panic(err)
+						return fmt.Errorf("failed to match regex for key '%s': %w", key, err)
 					} else if found {
 						break
 					}
@@ -285,22 +285,24 @@ func (r *paginatedResourceRepository[ResourceType, OptionsType, PaginationQueryT
 
 	finalQuery, err := r.buildFilteredDataset(resourceQuery)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("building filtered dataset: %w", err)
 	}
 
-	finalQuery = r.paginator.paginate(finalQuery, paginationOptions)
+	finalQuery, err = r.paginator.paginate(finalQuery, paginationOptions)
+	if err != nil {
+		return nil, fmt.Errorf("paginating request: %w", err)
+	}
 
 	finalQuery, err = r.expand(finalQuery, resourceQuery)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("expanding results: %w", err)
 	}
 	finalQuery = finalQuery.Order("row_number")
 
 	ret := make([]ResourceType, 0)
-	fmt.Println(finalQuery.Model(&ret).String())
 	err = finalQuery.Model(&ret).Scan(ctx)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("scanning results: %w", err)
 	}
 
 	return r.paginator.buildCursor(ret, paginationOptions)

internal/storage/ledger/resource_accounts.go

@@ -127,9 +127,9 @@ func (h accountsResourceHandler) resolveFilter(store *Store, opts ledgercontroll
 		return "metadata @> ?", []any{map[string]any{
 			match[0][1]: value,
 		}}, nil
+	default:
+		return "", nil, ledgercontroller.NewErrInvalidQuery("invalid filter property %s", property)
 	}
-
-	panic("unreachable")
 }
 
 func (h accountsResourceHandler) project(store *Store, query ledgercontroller.ResourceQuery[any], selectQuery *bun.SelectQuery) (*bun.SelectQuery, error) {

internal/storage/ledger/resource_transactions.go

@@ -146,11 +146,9 @@ func (h transactionsResourceHandler) resolveFilter(store *Store, opts ledgercont
 
 	case property == "metadata":
 		return "metadata -> ? is not null", []any{value}, nil
-	case property == "timestamp":
-		return fmt.Sprintf("timestamp %s ?", convertOperatorToSQL(operator)), []any{value}, nil
+	default:
+		return "", nil, fmt.Errorf("unsupported filter: %s", property)
 	}
-
-	panic("unreachable")
 }
 
 func (h transactionsResourceHandler) project(store *Store, query ledgercontroller.ResourceQuery[any], selectQuery *bun.SelectQuery) (*bun.SelectQuery, error) {
@@ -162,39 +160,6 @@ func (h transactionsResourceHandler) expand(store *Store, opts ledgercontroller.
 		return nil, nil, nil
 	}
 
-	/**
-	SELECT "transactions_id", public.aggregate_objects(post_commit_effective_volumes::JSONB) AS post_commit_effective_volumes
-	FROM (
-		SELECT "transactions_id", json_build_object(moves.accounts_address, json_build_object(moves.asset, json_build_object('input', (moves.post_commit_effective_volumes).inputs, 'output', (moves.post_commit_effective_volumes).outputs))) AS post_commit_effective_volumes
-	    FROM (
-			SELECT DISTINCT ON (transactions_id, accounts_address, asset)
-				"transactions_id",
-	            "accounts_address",
-	            "asset",
-	            first_value(moves.post_commit_effective_volumes)
-					OVER (PARTITION BY (transactions_id, accounts_address, asset) ORDER BY seq DESC) AS post_commit_effective_volumes
-	         FROM "_default".moves
-		) moves
-	) DATA
-	GROUP BY "transactions_id";
-
-	SELECT "transactions_id", public.aggregate_objects(json_build_object(accounts_address, post_commit_effective_volumes)::jsonb) AS post_commit_effective_volumes
-	FROM (
-		SELECT "transactions_id", "accounts_address", public.aggregate_objects(json_build_object(moves.asset, json_build_object('input', (moves.post_commit_effective_volumes).inputs, 'output', (moves.post_commit_effective_volumes).outputs))::jsonb) AS post_commit_effective_volumes
-		FROM (
-			SELECT DISTINCT ON (transactions_id, accounts_address, asset)
-				"transactions_id",
-				"accounts_address",
-				"asset",
-				first_value(moves.post_commit_effective_volumes)
-					OVER (PARTITION BY (transactions_id, accounts_address, asset) ORDER BY seq DESC) AS post_commit_effective_volumes
-			 FROM "_default".moves
-		) moves
-		GROUP BY "transactions_id", "accounts_address"
-	) data
-	GROUP BY "transactions_id";
-	*/
-
 	ret := store.db.NewSelect().
 		TableExpr(
 			"(?) data",

internal/storage/ledger/resource_volumes.go

@@ -179,9 +179,9 @@ func (h volumesResourceHandler) resolveFilter(
 				match[0][1]: value,
 			}}, nil
 		}
+	default:
+		return "", nil, fmt.Errorf("unsupported filter %s", property)
 	}
-
-	panic("unreachable")
 }
 
 func (h volumesResourceHandler) project(

internal/storage/ledger/utils.go

@@ -8,15 +8,13 @@ import (
 func isSegmentedAddress(address string) bool {
 	src := strings.Split(address, ":")
 
-	needSegmentCheck := false
 	for _, segment := range src {
-		needSegmentCheck = segment == ""
-		if needSegmentCheck {
-			break
+		if segment == "" {
+			return true
 		}
 	}
 
-	return needSegmentCheck
+	return false
 }
 
 func filterAccountAddress(address, key string) string {
@@ -39,15 +37,6 @@ func filterAccountAddress(address, key string) string {
 	return strings.Join(parts, " and ")
 }
 
-func isPartialAddress[V any](address V) bool {
-	switch address := any(address).(type) {
-	case string:
-		for _, segment := range strings.Split(address, ":") {
-			if segment == "" {
-				return true
-			}
-		}
-	}
-
-	return false
+func isPartialAddress(address any) bool {
+	return isSegmentedAddress(address.(string))
 }