fix(listAtom): update the inner fieldAtom's name with current list name & position (#109)
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test(listAtom): scoped names * listItem as extended formAtom with name * use extended listItemForm * fix types so build passes * add effect for syncing field names * docs(List): add names * test(listAtom): the indexes are updated for current values * docs: add feature for scoped names * fix compouning names, drop the scoped atom once the fields unmount.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 90.52% 91.23% +0.70%
==========================================
Files 100 101 +1
Lines 2513 2737 +224
Branches 196 215 +19
==========================================
+ Hits 2275 2497 +222
- Misses 238 240 +2 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 4.0.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
test(listAtom): scoped names
listItem as extended formAtom with name
use extended listItemForm
fix types so build passes
add effect for syncing field names
docs(List): add names
test(listAtom): the indexes are updated for current values
docs: add feature for scoped names
fix compouning names, drop the scoped atom once the fields unmount.