Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W-7158536] Add dependabot config #40

Closed
wants to merge 1 commit into from
Closed

[W-7158536] Add dependabot config #40

wants to merge 1 commit into from

Conversation

bpbuch
Copy link
Contributor

@bpbuch bpbuch commented Feb 7, 2020

What does this PR do?

Add Dependabot config

What issues does this PR fix or reference?

@W-7158536@

@bpbuch bpbuch requested a review from nrkruk February 7, 2020 18:28
@@ -0,0 +1,10 @@
version: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be in our packages specifically?

Copy link
Contributor Author

@bpbuch bpbuch Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It can be at the root and watch all nested packages.

Edit: It actually has to be at the root of the repository for the config to be picked up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is the language server, duh

- package_manager: "javascript"
directory: "/"
update_schedule: "daily"
allowed_updates:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it will only send updates for our own stuff. Wouldn't it be better to do updates for anything, i.e. the vscode language server also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am open to having dependabot watch all dependencies. I believe @nrkruk had some reservations about this.

@mysticflute
Copy link
Contributor

@bpbuch is there some way to send group PRs for everything under @lwc? I think the individual PRs will cause CI problems since there could be incompatible changes sometimes

@bpbuch
Copy link
Contributor Author

bpbuch commented Feb 7, 2020

Not that I am aware of. There is an open issue from others requesting this as a feature.

dependabot/dependabot-core#1296

@nrkruk nrkruk closed this Feb 18, 2020
@bpbuch bpbuch deleted the W-7158536 branch February 20, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants