did a lot #17
Open
did a lot #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switched to BOOTSTRA.386, made the code cleaner, added a new spinner.gif that was generated from the msdos font and GIMP, had WAY too much fun working on this! I tried to set up my GitHub pages to host it so you can see what it looks like, but I would have to change your CNAMES file making a pull request harder to accept, so instead, I uploaded it to an Amazon S3 bucket so you can click around. Here is the URL:
http://s3-us-west-2.amazonaws.com/jason.sperske.com/SierraDeathGenerator/index.html
I would like to have made more code cleanups but I didn't want to mess with the logic too much as it might make maintenance harder for you (at least initially), but if this PR is accepted then I could possibly refactor the JavaScript to make something that doesn't use as much global scope and I believe would be easier to reason about.