Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent adding user to multiple order groups #993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent adding user to multiple order groups #993

wants to merge 1 commit into from

Conversation

aban1
Copy link

@aban1 aban1 commented Apr 11, 2023 •
edited by kidhab
Loading

I was aiming to resolve #967 of adding an error message for when someone tries to join multiple order groups.

@kidhab
Copy link
Contributor

kidhab commented Apr 11, 2023

Thanks for your contribution. Can you please remove the commits that contain comments as the only change?

@aban1
Copy link
Author

aban1 commented Apr 11, 2023 via email

@kidhab
Copy link
Contributor

kidhab commented Apr 12, 2023

There are still two commits left that addresses other issues. Can you please remove them from this MR?

@aban1
Copy link
Author

aban1 commented Apr 12, 2023

Again so sorry I forgot to switch branches before starting to work on a new task. I just removed those two from this PR. Thank you for your patience.

@kidhab
Copy link
Contributor

kidhab commented Apr 21, 2023

I just tested it. Your change prevents updating an existing ordergroup because the uniqueness check fails for existing ordergroup members. Can you try it on you instance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent adding user to multiple ordergroups
2 participants
@aban1 @kidhab