Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with Fontspector #4865

Closed
felipesanches opened this issue Oct 21, 2024 · 2 comments
Closed

Sync with Fontspector #4865

felipesanches opened this issue Oct 21, 2024 · 2 comments
Assignees
@felipesanches
Milestone
0.13.0

Comments

@felipesanches
Copy link
Collaborator

felipesanches commented Oct 21, 2024 •
edited
Loading

There are a few checks in fontspector that were implemented (in rust) by merging multiple fontbakery checks.

As in the long term I expect fontspector to become Fontbakery itself, I think it is wise to keep track of those changes and apply them to the python codebase as well.

First step is to make a list of those few cases.
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 30, 2024
@felipesanches
Deprecate opentype/dsig
0b40c47 
Removed from the 'OpenType' profile.
Merged into 'unwanted_tables' on the 'Universal' profile.

(issue fonttools#4865)
@felipesanches felipesanches mentioned this issue Oct 30, 2024
Merged
felipesanches added a commit that referenced this issue Oct 30, 2024
@felipesanches
Deprecate opentype/dsig
83966c8 
Removed from the 'OpenType' profile.
Merged into 'unwanted_tables' on the 'Universal' profile.

(issue #4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/fvar/axis_ranges_correct
e14be6e 
Following FontSpector.

New check:
 - opentype/fvar/axis_ranges_correct

Old checks:
 - opentype/varfont/ital_range
 - opentype/varfont/slnt_range
 - opentype/varfont/wdth_valid_range
 - opentype/varfont/wght_valid_range

On the OpenType profile.

(issue fonttools#4865)
@felipesanches felipesanches mentioned this issue Nov 14, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/fvar/axis_ranges_correct
d43afb9 
Following FontSpector.

New check:
 - opentype/fvar/axis_ranges_correct

Old checks:
 - opentype/varfont/ital_range
 - opentype/varfont/slnt_range
 - opentype/varfont/wdth_valid_range
 - opentype/varfont/wght_valid_range

On the OpenType profile.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/fvar/axis_ranges_correct
3e6ebf1 
Following FontSpector.

New check:
 - opentype/fvar/axis_ranges_correct

Old checks:
 - opentype/varfont/ital_range
 - opentype/varfont/slnt_range
 - opentype/varfont/wdth_valid_range
 - opentype/varfont/wght_valid_range

On the OpenType profile.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/fvar/axis_ranges_correct
fe4e6e6 
Following FontSpector.

New check:
 - opentype/fvar/axis_ranges_correct

Old checks:
 - opentype/varfont/ital_range
 - opentype/varfont/slnt_range
 - opentype/varfont/wdth_valid_range
 - opentype/varfont/wght_valid_range

On the OpenType profile.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/fvar/axis_ranges_correct
c039dab 
Following FontSpector.

New check:
 - opentype/fvar/axis_ranges_correct

Old checks:
 - opentype/varfont/ital_range
 - opentype/varfont/slnt_range
 - opentype/varfont/wdth_valid_range
 - opentype/varfont/wght_valid_range

On the OpenType profile.

(issue fonttools#4865)
felipesanches added a commit that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/fvar/axis_ranges_correct
313d706 
Following FontSpector.

New check:
 - opentype/fvar/axis_ranges_correct

Old checks:
 - opentype/varfont/ital_range
 - opentype/varfont/slnt_range
 - opentype/varfont/wdth_valid_range
 - opentype/varfont/wght_valid_range

On the OpenType profile.

(issue #4865)
@felipesanches felipesanches added this to the 0.13.0 milestone Nov 14, 2024
@felipesanches felipesanches self-assigned this Nov 14, 2024
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/varfont/valid_nameids
4e7c42e 
Following FontSpector.

New check:
 - opentype/varfont/valid_nameids

Old checks:
 - opentype/varfont/valid_axis_nameid
 - opentype/varfont/valid_postscript_nameid
 - opentype/varfont/valid_subfamily_nameid

On the OpenType profile.

(issue fonttools#4865)
@felipesanches felipesanches mentioned this issue Nov 14, 2024
Merged
felipesanches added a commit that referenced this issue Nov 14, 2024
@felipesanches
Merge a few checks into opentype/varfont/valid_nameids
e581c09 
Following FontSpector.

New check:
 - opentype/varfont/valid_nameids

Old checks:
 - opentype/varfont/valid_axis_nameid
 - opentype/varfont/valid_postscript_nameid
 - opentype/varfont/valid_subfamily_nameid

On the OpenType profile.

(issue #4865)
@felipesanches
Copy link
Collaborator Author

Do not forget issue #4906 as well.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 15, 2024
@felipesanches
Merge a few checks into opentype/fvar/regular_coords_correct
34f9e59 
Following FontSpector.

New check:
 - opentype/fvar/regular_coords_correct

Old checks:
 - opentype/varfont/regular_ital_coord
 - opentype/varfont/regular_opsz_coord
 - opentype/varfont/regular_slnt_coord
 - opentype/varfont/regular_wdth_coord
 - opentype/varfont/regular_wght_coord

On the OpenType profile.

(issue fonttools#4865)
@felipesanches felipesanches mentioned this issue Nov 15, 2024
Merged
felipesanches added a commit that referenced this issue Nov 15, 2024
@felipesanches
Merge a few checks into opentype/fvar/regular_coords_correct
c995480 
Following FontSpector.

New check:
 - opentype/fvar/regular_coords_correct

Old checks:
 - opentype/varfont/regular_ital_coord
 - opentype/varfont/regular_opsz_coord
 - opentype/varfont/regular_slnt_coord
 - opentype/varfont/regular_wdth_coord
 - opentype/varfont/regular_wght_coord

On the OpenType profile.

(issue #4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 6, 2024
@felipesanches
Ligature_carets (sync with fontspector)
5e3065d 
(issue fonttools#4865 / simoncozens/fontspector@907d865)
@felipesanches felipesanches mentioned this issue Dec 6, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 6, 2024
@felipesanches
Ligature_carets (sync with fontspector)
f5c5be1 
(issue fonttools#4865 / simoncozens/fontspector@907d865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 6, 2024
@felipesanches
Ligature_carets (sync with fontspector)
c8e6eff 
(issue fonttools#4865 / simoncozens/fontspector@907d865)
felipesanches added a commit that referenced this issue Dec 6, 2024
@felipesanches
Ligature_carets (sync with fontspector)
8d68dd6 
(issue #4865 / simoncozens/fontspector@907d865)
@felipesanches felipesanches mentioned this issue Dec 26, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
d5a2e26 
Following FontSpector.
(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
2d940b5 
Following FontSpector.
(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
6ef9aef 
Backporting from FontSpector.
(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
140fcc0 
Backporting from FontSpector.
(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
fe9af46 
Backporting from FontSpector.
(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
7015791 
Backporting from FontSpector.
(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
155d096 
Backporting from FontSpector.
(issue fonttools#4865)
felipesanches added a commit that referenced this issue Dec 26, 2024
@felipesanches
Merge opentype/fsselection_matches_macstyle into opentype/fsselection
a789ffa 
Backporting from FontSpector.
(issue #4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 27, 2024
@felipesanches
new check: STAT/ital_axis
5050a74 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
@felipesanches felipesanches mentioned this issue Dec 27, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 27, 2024
@felipesanches
new check: STAT/ital_axis
8bfeb01 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 27, 2024
@felipesanches
new check: STAT/ital_axis
c4a637e 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 27, 2024
@felipesanches
new check: STAT/ital_axis
d654ed0 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 27, 2024
@felipesanches
new check: STAT/ital_axis
4fc667e 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 27, 2024
@felipesanches
new check: STAT/ital_axis
7d02695 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 28, 2024
@felipesanches
new check: STAT/ital_axis
dc8b41f 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 28, 2024
@felipesanches
new check: STAT/ital_axis
87ce000 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 28, 2024
@felipesanches
new check: STAT/ital_axis
09a19ab 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 28, 2024
@felipesanches
new check: STAT/ital_axis
1ca818a 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 28, 2024
@felipesanches
new check: STAT/ital_axis
b161143 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue fonttools#4865)
felipesanches added a commit that referenced this issue Dec 28, 2024
@felipesanches
new check: STAT/ital_axis
83db7cc 
Added to the OpenType profile.

Replaces the old checks (also from OpenType profile):
- opentype/italic_axis_in_stat
- opentype/italic_axis_in_stat_is_boolean
- opentype/italic_axis_last

Large chunk of code back-ported from FontSpector.

(issue #4865)
@felipesanches
Copy link
Collaborator Author

I think I'm done here ;-)

Off-course, this is a moving target, but there's no need of an issue anymore, as the bulk of the work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
1 participant
@felipesanches