Deprecate opentype/dsig

Removed from the 'OpenType' profile. Merged into 'unwanted_tables' on the 'Universal' profile. (issue fonttools#4865)
felipesanches · Oct 30, 2024 · 0b40c47 · 0b40c47
1 parent 994ff35
commit 0b40c47
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 71 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,9 @@ Below are the noteworthy changes from each release.
 A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).
 
 ##  Upcoming release: 0.13.0 (a4?) (2024-Nov-??)
-  - ...
+### Deprecated checks
+#### Removed from the OpenType profile
+  - **DEPRECATED - [opentype/dsig]:** Merged into **[unwanted_tables]** on the `Universal` profile. (issue #4865)
 
 
 ## 0.13.0a3 (2024-Oct-25)

diff --git a/Lib/fontbakery/checks/opentype/dsig.py b/Lib/fontbakery/checks/opentype/dsig.py
diff --git a/Lib/fontbakery/checks/tables.py b/Lib/fontbakery/checks/tables.py
@@ -128,6 +128,12 @@ def check_required_tables(ttFont, config, is_variable_font):
 def check_unwanted_tables(ttFont):
     """Are there unwanted tables?"""
     UNWANTED_TABLES = {
+        "DSIG": (
+            "This font has a digital signature (DSIG table) which is only required"
+            " - even if only a placeholder - on old programs like MS Office 2013"
+            " in order to work properly.\n"
+            "The current recommendation is to completely remove the DSIG table."
+        ),
         "FFTM": "Table contains redundant FontForge timestamp info",
         "TTFA": "Redundant TTFAutohint table",
         "TSI0": "Table contains data only used in VTT",

diff --git a/Lib/fontbakery/profiles/adobefonts.py b/Lib/fontbakery/profiles/adobefonts.py
@@ -28,7 +28,6 @@
         "notofonts/unicode_range_bits",  # so maybe there's still some change they may be considered useful here?
         #
         "opentype/caret_slope",
-        "opentype/dsig",
         "opentype/fsselection",
         "opentype/gdef_mark_chars",
         "opentype/gdef_non_mark_chars",

diff --git a/Lib/fontbakery/profiles/opentype.py b/Lib/fontbakery/profiles/opentype.py
@@ -8,7 +8,6 @@
             "opentype/cff_call_depth",
             "opentype/cff_deprecated_operators",
             "opentype/code_pages",
-            "opentype/dsig",
             "opentype/family/bold_italic_unique_for_nameid1",
             "opentype/family/consistent_family_name",
             "opentype/family/equal_font_versions",

diff --git a/docs/source/fontbakery/checks/opentype.rst b/docs/source/fontbakery/checks/opentype.rst
@@ -14,12 +14,6 @@ CFF table checks
 .. automodule:: fontbakery.checks.opentype.cff
     :members:
 
-DSIG table checks
-*****************
-
-.. automodule:: fontbakery.checks.opentype.dsig
-    :members:
-
 fvar table checks
 *****************
 

diff --git a/tests/test_checks_opentype_dsig.py b/tests/test_checks_opentype_dsig.py
diff --git a/tests/test_checks_universal.py b/tests/test_checks_universal.py
@@ -684,6 +684,7 @@ def test_check_unwanted_tables():
     check = CheckTester("unwanted_tables")
 
     unwanted_tables = [
+        "DSIG",
         "FFTM",  # FontForge
         "TTFA",  # TTFAutohint
         "TSI0",  # TSI* = VTT