Skip to content

Commit

Permalink
Also consider the case of glyphs which are components only of unreach…
Browse files Browse the repository at this point in the history
…able glyphs.

com.google.fonts/check/unreachable_glyphs
On the Universal Profile

(issue #4378)
  • Loading branch information
felipesanches committed Feb 6, 2024
1 parent 5b2c9b0 commit b350861
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ A more detailed list of changes is available in the corresponding milestones for
- Fixed HTML reporter by adding the templates directory to the fontbakery package. (issue #4479)
- Minor wording improvement on the GHMarkdown reporter (issue #4492)

### Changes to existing checks
#### On the Universal Profile
- **[com.google.fonts/check/unreachable_glyphs]:** Also consider the case of glyphs which are components only of unreachable glyphs. (issue #4378)


## 0.11.0 (2024-Feb-02)
### Noteworthy code-changes
- The babelfont dependency has been dropped. (PR #4416)
Expand Down
2 changes: 1 addition & 1 deletion Lib/fontbakery/profiles/universal.py
Original file line number Diff line number Diff line change
Expand Up @@ -1599,7 +1599,7 @@ def remove_lookup_outputs(all_glyphs, lookup):
if "glyf" in ttFont:
for glyph_name in ttFont["glyf"].keys():
base_glyph = ttFont["glyf"][glyph_name]
if base_glyph.isComposite():
if base_glyph.isComposite() and glyph_name not in all_glyphs:
all_glyphs -= set(base_glyph.getComponentNames(ttFont["glyf"]))

if all_glyphs:
Expand Down

0 comments on commit b350861

Please sign in to comment.