Add support for inserting pages #997
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We will need some tests. Also look at the review notes |
blikblum
requested changes
Jul 9, 2019
| @@ -9,7 +9,7 @@ | |||
| "document", | |||
| "vector" | |||
| ], | |||
| "version": "0.10.0", | |||
| "version": "0.11.0", | |||
There was a problem hiding this comment.
Do not update the version in package.json. It's done when a release is prepared
| @@ -305,7 +305,7 @@ class LineWrapper extends EventEmitter { | |||
| return false; | |||
| } | |||
|
|
|||
| this.document.addPage(); | |||
| this.document.addPageAfterThis(); | |||
There was a problem hiding this comment.
For safety this needs to be kept as addPage
| return this; | ||
| } | ||
|
|
||
| addPageAfterThis(options) { |
There was a problem hiding this comment.
For now i would not add this method. Can be added later with a clear use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a change that allows pages to be inserted through an
insertPage(at, options)method.Also, when continuing pages, it will try to insert a page after the current one.
It will throw an error if option
bufferPagesis not set.