Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use font name (or id as fallback) to identify font #692

Closed
wants to merge 1 commit into from
Closed

Use font name (or id as fallback) to identify font #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/mixins/fonts.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,21 @@ module.exports =
id = 'F' + (++@_fontCount)
@_font = PDFFont.open(this, src, family, id)

# use font name (or id as fallback) to identify font
name = @_font.name || id

# check for existing font familes with the same name already in the PDF
# useful if the font was passed as a buffer
if font = @_fontFamilies[@_font.name]
if font = @_fontFamilies[name]
@_font = font
return this

# save the font for reuse later
if cacheKey
@_fontFamilies[cacheKey] = @_font

if @_font.name
@_fontFamilies[@_font.name] = @_font
if name
@_fontFamilies[name] = @_font

return this

Expand Down