UIU-3119: Pronoun Field - User Record Edit

[s3fs]

Add pronouns field to user edit view and display pronouns in its header alongside with user's name if they're present.

https://folio-org.atlassian.net/browse/UIU-3119

[zburke]

Dropping support for an interface version is a breaking change. You must update the major version of this package in package.json or surround this new functionality with an <IfInterface> conditional that specifies the minimum version.

[s3fs]

Done @zburke. Could you please check if it's correct?

[zburke]

Full disclosure: I saw the updated okapiInterface version in the first revision and did not read past that for my initial review.

Now that I'm looking at the details, this work may be backwards compatible depending how mod-users is implemented. If it ignores unknown fields (as it should IMO) then you're safe and the original commit, sans the interface version update, would be just fine. If mod-users panics when it receives unknown fields, as many of our modules do 🙄 , then we do need to bump the interface version. In any case, the current implementation is correct, and if you're happy with it then so am I.

[s3fs]

the original commit, sans the interface version update, would be just fine.

Not sure I understand this part @zburke. How would this work if we're not specifying the interface version required for this frontend functionality to work?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[zburke]

An okapiInterface dependency like 16.3 is equivalent to ^16.3 (I have no idea why the syntax is different) so if the new fields were truly optional on the FE and BE, then the original PR could have been OK in the sense that "submitting a form with unsupported but optional fields would not cause an error". Showing fields that wouldn't be saved would not be a great experience, of course, but it wouldn't be an error either.

[s3fs]

I have tested it locally with okapiInterfaces set to "users": "16.3" against https://folio-dev-volaris-okapi.ci.folio.org and it works fine. I guess it would be better to remove the version bumps I've done then? @zburke

[zburke]

I have tested it locally with okapiInterfaces set to "users": "16.3" against https://folio-dev-volaris-okapi.ci.folio.org and it works fine. I guess it would be better to remove the version bumps I've done then?

Setting the interface version in UI code isn't the thing you need to test here. You need to test against a BE that only provides 16.3.