Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3047 - max profile picture size (follow-up) #2693

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

manvendra-s-rathore
Copy link
Contributor

@manvendra-s-rathore manvendra-s-rathore commented May 20, 2024

UIU-3047

Purpose

This PR is to address review comment on PR - #2648.

Approach

Rename PROFILE_PIC_DEFAULT_MAX_SIZE constant to PROFILE_PIC_DEFAULT_MAX_SIZE_IN_MB in order to specify the size type i.e. MB.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@manvendra-s-rathore manvendra-s-rathore marked this pull request as ready for review May 20, 2024 11:12
@manvendra-s-rathore manvendra-s-rathore requested review from Terala-Priyanka and removed request for Terala-Priyanka May 20, 2024 11:12
Copy link

@manvendra-s-rathore manvendra-s-rathore requested a review from a team May 21, 2024 04:48
@manvendra-s-rathore manvendra-s-rathore merged commit c666aba into master May 21, 2024
5 checks passed
@zburke zburke deleted the UIU-3047-2 branch October 25, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants