Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3016 - Include DCB in 'User Type' search filter group #2681

Merged
merged 3 commits into from
May 7, 2024

Conversation

manvendra-s-rathore
Copy link
Contributor

@manvendra-s-rathore manvendra-s-rathore commented May 2, 2024

UIU-3016 - Include DCB in 'User Type' search filter group.

Screencast

dcb.filter.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@manvendra-s-rathore manvendra-s-rathore marked this pull request as draft May 3, 2024 10:20
@manvendra-s-rathore manvendra-s-rathore marked this pull request as ready for review May 6, 2024 13:00
@manvendra-s-rathore manvendra-s-rathore requested review from Terala-Priyanka and a team May 6, 2024 13:02
@manvendra-s-rathore manvendra-s-rathore changed the title UIU-3016 - DCB user type as filter option in Users Search UIU-3016 - Include DCB in 'User Type' search filter group May 6, 2024
@manvendra-s-rathore manvendra-s-rathore requested a review from a team May 6, 2024 15:13
@manvendra-s-rathore
Copy link
Contributor Author

Hey @folio-org/fe-tl-reviewers can someone please review this PR.

Copy link

sonarqubecloud bot commented May 7, 2024

@manvendra-s-rathore manvendra-s-rathore merged commit ac8d11e into master May 7, 2024
5 checks passed
@zburke zburke deleted the UIU-3016-2 branch October 25, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants