Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3025 - Create new permission 'Users: Can view, edit, and delete profile pictures' #2619

Merged
merged 3 commits into from
Jan 30, 2024
Merged

UIU-3025 - Create new permission 'Users: Can view, edit, and delete profile pictures' #2619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4023bf8
UIU-3025 - Create new permission 'Users: Can view, edit, and delete p…
Terala-Priyanka Jan 29, 2024
4f02d15
UIU-3025 - fix review comment
Terala-Priyanka Jan 29, 2024
058abbb
UIU-3025 - rename permission translations too
Terala-Priyanka Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
* Show country name in user address instead of country id. Refs UIU-2976.
* Add patron notice print jobs to action menu. Refs UIU-3029.
* Update sub permissions of permission 'Users: Can view user profiles'. Refs UIU-3038.
* Create new permission 'Users: Can view, edit, and delete profile pictures'. Refs UIU-3025.

## [10.0.4](https://github.com/folio-org/ui-users/tree/v10.0.4) (2023-11-10)
[Full Changelog](https://github.com/folio-org/ui-users/compare/v10.0.3...v10.0.4)
Expand Down
14 changes: 14 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,20 @@
],
"visible": true
},
{
"permissionName": "ui-users.profilepictures.all",
"displayName": "Users: Can view, edit, and delete profile pictures",
"description": "Also includes basic permissions to edit user profile",
"subPermissions": [
"ui-users.profilepictures.view",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use profile-picture in place of profilepicture. Petty, sorry; developers are so cranky about names 😅 Be consistent with the name already established in the back-end permissions. Alas, consistency on single vs plural is a battle I lost years ago. Curse DHH and his awful Rails ORM naming conventions, the worst decision he ever made.

"ui-users.edit",
"users.profile-picture.item.post",
"users.profile-picture.item.put",
"users.profile-picture.item.delete"

],
"visible": true
},
{
"permissionName": "ui-users.settings.general.view",
"displayName": "Settings (Users): Can view general entries",
Expand Down
1 change: 1 addition & 0 deletions translations/ui-users/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,6 +1011,7 @@
"permission.manual_waive": "Fees/Fines: Can waive",
"permission.patron_blocks": "Users: Can create, edit and remove patron blocks",
"permission.profilepictures.view": "Users: Can view profile pictures",
"permission.profilepictures.all": "Users: Can view, edit, and delete profile pictures",
"permission.requests.all": "Users: View requests",
"permission.reset.password": "Users: Create/reset password",
"permission.settings.view": "Settings (Users): View all settings",
Expand Down
Loading