Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-570 Downloading files from Logs tab #676

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Jan 21, 2025

In scope of this PR reworked part related to download files from Logs tab.

  • Constants related to links were cleaned
  • File name will be taken from BE instead of hardcoding on UI (getFileName function removed with all tests as not used)
  • added MARC and CSV parts to link names

Refs: UIBULKED-570

Note: code coverage is lower then 80% because constants was changed in places with low coverage. Increasing this coverage out of scope.

Copy link

github-actions bot commented Jan 21, 2025

Jest Unit Test Statistics

    1 files  ±0    52 suites  ±0   3m 23s ⏱️ +3s
323 tests  - 3  323 ✔️  - 3  0 💤 ±0  0 ±0 
330 runs   - 3  330 ✔️  - 3  0 💤 ±0  0 ±0 

Results for commit 3bf4c41. ± Comparison against base commit 9128145.

This pull request removes 3 tests.
files getFileName should return the correct file name for Query approach - linkToMatchedRecordsCsvFile ‑ files getFileName should return the correct file name for Query approach - linkToMatchedRecordsCsvFile
files getFileName should return the correct file name for Query approach - linkToTriggeringCsvFile ‑ files getFileName should return the correct file name for Query approach - linkToTriggeringCsvFile
files getFileName should return the correct file name for non-Query approach ‑ files getFileName should return the correct file name for non-Query approach

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 21, 2025

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 3bf4c41. ± Comparison against base commit 9128145.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@vashjs vashjs marked this pull request as ready for review January 21, 2025 22:42
@vashjs vashjs requested review from UladzislauKutarkin and a team January 21, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants