[MODEBSNET-41] Release Morning Glory 2022 R2 Bug Fix 1 (#59)

R2 2022 Morning Glory Bug Fix 1 Deployment
folio-org · Jul 27, 2022 · aa40005 · aa40005
1 parent 757dd3b
commit aa40005
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,14 @@
 ## 1.4.0 - Unreleased
 
+## 1.3.1 (Bug Fix) - Released
+This release focused on fixing issue when renewal note becomes blank after Gobi order update
+
+[Full Changelog](https://github.com/folio-org/mod-orders/compare/v1.3.0...v1.3.1)
+
+### Bug Fixes
+* [MODEBSNET-39](https://issues.folio.org/browse/MODEBSNET-39) - Renewal note is blank after update
+
+
 ## 1.3.0 Morning Glory R2 2022 - Released
 This release contains update logic to support customer note, renwal note, cancelling POL(s) through EBSCONET integration
 

diff --git a/descriptors/ModuleDescriptor-template.json b/descriptors/ModuleDescriptor-template.json
@@ -30,7 +30,7 @@
   "provides": [
     {
       "id": "ebsconet",
-      "version": "1.0",
+      "version": "2.0",
       "handlers": [
         {
           "methods": [

diff --git a/src/main/java/org/folio/ebsconet/mapper/OrdersMapper.java b/src/main/java/org/folio/ebsconet/mapper/OrdersMapper.java
@@ -50,7 +50,7 @@ public abstract class OrdersMapper {
   @Mapping(target = "publisherName", source = "line.publisher")
   @Mapping(target = "vendorAccountNumber", source = "line.vendorDetail.vendorAccount")
   @Mapping(target = "workflowStatus", source = "order.workflowStatus")
-  @Mapping(target = "renewalNote", source = "line.renewalNote")
+  @Mapping(target = "internalNote", source = "line.renewalNote")
   public abstract EbsconetOrderLine folioToEbsconet(PurchaseOrder order, PoLine line, Organization vendor);
 
   @Named("getFundCode")
@@ -89,7 +89,7 @@ public void ebsconetToFolio(MappingDataHolder mappingDataHolder) {
     poLine.getDetails().setSubscriptionFrom(ebsconetOrderLine.getSubscriptionFromDate());
     poLine.getVendorDetail().setVendorAccount(ebsconetOrderLine.getVendorAccountNumber());
     poLine.setPublisher(ebsconetOrderLine.getPublisherName());
-    poLine.setRenewalNote(mappingDataHolder.getEbsconetOrderLine().getRenewalNote());
+    poLine.setRenewalNote(mappingDataHolder.getEbsconetOrderLine().getInternalNote());
 
     populateCostAndLocations(poLine, ebsconetOrderLine);
     removeZeroAmountLocations(poLine);

diff --git a/src/main/resources/swagger.api/schemas/mod-ebsconet/ebsconet_order_line.json b/src/main/resources/swagger.api/schemas/mod-ebsconet/ebsconet_order_line.json
@@ -34,7 +34,7 @@
       "description": "Publisher of the material",
       "readOnly": false
     },
-    "renewalNote": {
+    "internalNote": {
       "type": "string",
       "description": "Renewal note for this purchase order line"
     },

diff --git a/src/test/java/org/folio/ebsconet/OrdersServiceTest.java b/src/test/java/org/folio/ebsconet/OrdersServiceTest.java
@@ -224,7 +224,7 @@ void shouldCallPutIfCallUpdateEbsconetOrderLine(){
     EbsconetOrderLine ebsconetOrderLine = getSampleEbsconetOrderLine("CODE", 1);
 
     var testRenewalNote = "Test renewal Note";
-    ebsconetOrderLine.renewalNote(testRenewalNote);
+    ebsconetOrderLine.internalNote(testRenewalNote);
     var poLineNumber = "10000-1";
     var polResult = new PoLineCollection();
     var poLine = new PoLine();