-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODDCB-124: Merge branch ecs-tlr
into master
#115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sServiceImpl.java Co-authored-by: Roman Barannyk <[email protected]>
MODDCB-90 Accept existing circulation request ID
…s-tlr # Conflicts: # descriptors/ModuleDescriptor-template.json # src/main/resources/swagger.api/dcb_transaction.yaml
…action) (#82) * MODDCB-105 Accept existing circulation request ID (borrowing transaction) * MODDCB-105 Accept existing circulation request ID (borrowing transaction) * MODDCB-105 Accept existing circulation request ID (borrowing transaction) * MODDCB-105 Accept existing circulation request ID (borrowing transaction) * MODDCB-105 Accept existing circulation request ID (borrowing transaction)
* Lender transaction CREATED -> OPEN * MODDCB-111 Remove redundant test case
[MODDCB-117] Add ecsRequestPhase to moddcb circulation request schema
[MODDCB-122] Add position field to request schema
|
alexanderkurash
approved these changes
Nov 4, 2024
roman-barannyk
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Merge branch
ecs-tlr
intomaster
.MODDCB-124
Approach
How does this change fulfill the purpose?
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.