Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIRC-2036] Add new 'displaySummarry' field to the Item schema #1438

Merged
merged 8 commits into from
Mar 7, 2024
Merged

[CIRC-2036] Add new 'displaySummarry' field to the Item schema #1438

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f00a79f
[MODORDERS-1017] - Add displaySummary field
Feb 12, 2024
73e7d1f
[MODORDERS-1017] - Add displaySummary field
Feb 13, 2024
52fa4f8
CIRC-2036 update schema with displaySummary field
roman-barannyk Mar 7, 2024
2d29831
CIRC-2036 fix code smell issue
roman-barannyk Mar 7, 2024
050ea69
CIRC-2036 fix code smell
roman-barannyk Mar 7, 2024
6357e28
CIRC-2036 refactoring
roman-barannyk Mar 7, 2024
f6e3b8d
CIRC-2036 Fix Sonar reliability issue
alexanderkurash Mar 7, 2024
1ec7b3b
CIRC-2036 refactoring
roman-barannyk Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
CIRC-2036 fix code smell
@roman-barannyk
roman-barannyk committed Mar 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 050ea69baef3f64a4dbdaee179f5c01471535631
2 changes: 1 addition & 1 deletion src/main/java/org/folio/circulation/domain/notice/TemplateContextUtil.java
View file
Original file line number Diff line number Diff line change
@@ -98,7 +98,7 @@ public static JsonObject createCheckInContext(CheckInContext context) {
JsonObject staffSlipContext = createStaffSlipContext(item, firstRequest);
JsonObject itemContext = staffSlipContext.getJsonObject(ITEM);

if (item != null && itemContext != null) {
if (ObjectUtils.allNotNull(item, itemContext)) {
write(itemContext, "lastCheckedInDateTime", ClockUtil.getZonedDateTime());
if (item.getInTransitDestinationServicePoint() != null) {
itemContext.put("toServicePoint", item.getInTransitDestinationServicePoint().getName());